Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

when sending blocks in bitswap, close streams asynchronously #5258

Merged
merged 1 commit into from
Jul 18, 2018
Merged

when sending blocks in bitswap, close streams asynchronously #5258

merged 1 commit into from
Jul 18, 2018

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Jul 18, 2018 •
edited
Loading

Otherwise, we tie up the bitswap worker until the other side responds with an EOF.

fixes #5247
related to libp2p/go-libp2p-net#28

@Stebalien
when sending blocks in bitswap, close streams asynchronously
3e30658 
Otherwise, we tie up the bitswap worker until the other side responds with an EOF.

fixes #5247
related to libp2p/go-libp2p-net#28

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien Stebalien requested a review from Kubuxu as a code owner July 18, 2018 16:57
@ghost ghost assigned Stebalien Jul 18, 2018
@ghost ghost added the status/in-progress In progress label Jul 18, 2018
@Stebalien Stebalien requested a review from magik6k July 18, 2018 16:57
@Stebalien Stebalien added need/review Needs a review P0 Critical: Tackled by core team ASAP labels Jul 18, 2018
magik6k
magik6k approved these changes Jul 18, 2018
View reviewed changes
Copy link
Member

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried with js-ipfs, works way better!

@magik6k
Copy link
Member

magik6k commented Jul 18, 2018

(very heavy example connecting to my server running this patch: https://ipfs.io/ipfs/QmZndUQvURHYJTgFJCfdhHDTKsDPMZffrJreGf2eAf9uPb/#/repo/QmU1HJJDFSM8JJq4r31wSLfj51oysQCswz7aL78UWZHuMC/compare/master...feat%2Fcoreapi-paths)

@Stebalien
Copy link
Member Author

Yeah, the memory issues don't look too bad. I'm working on a less crappy fix but it'll take a bit of time.

@Stebalien Stebalien added RFM and removed status/in-progress In progress need/review Needs a review labels Jul 18, 2018
@whyrusleeping whyrusleeping merged commit 6f140d2 into master Jul 18, 2018
@whyrusleeping whyrusleeping deleted the fix/5247 branch July 18, 2018 19:28
@magik6k magik6k mentioned this pull request Jul 18, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magik6k magik6k magik6k approved these changes

@Kubuxu Kubuxu Awaiting requested review from Kubuxu

Assignees

@Stebalien Stebalien

Labels
P0 Critical: Tackled by core team ASAP RFM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Closing streams and bitswap
3 participants
@Stebalien @magik6k @whyrusleeping